fix: Release full-quantize lookup on repeated setup - #905
Closed
carrerasdarren-cell wants to merge 1 commit into
Closed
fix: Release full-quantize lookup on repeated setup#905carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
Contributor
|
Same as #904 You are insisting on some etiolated idea of how to write code that does not comport with ANSI-C. The data must be released when the png_struct (in this case) or png_info (in the other) is free'ed; in other words the data must be released when the app cleans up. I suggest that submitted the same bug report multiple times is not productive. |
Author
|
Closing this narrower follow-up to avoid duplicating the repeated-setter premise already under discussion in #904. I will keep any further evidence consolidated there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
png_set_quantize()may be called more than once on the samepng_struct, asclarified while fixing #690. The earlier fix covers
quantize_indexin thenon-full-quantize branch, but the full-quantize branch still overwrites
palette_lookupon every call. With the default quantization bit widths, eachrepeated call leaks 32,768 bytes.
The explicit
NULLassignment also follows the allocation-failure cleanuppattern used for the other
png_structmembers fixed in a22696b.Verification
live_bytes=32768after two calls onthe unmodified branch and
live_bytes=0with this change.ctest --test-dir build-leak-proof --output-on-failure -j2passes all 37tests.