Harden metadata and chunk validation - #908
Conversation
|
Hello is there any update. |
|
Hi, just following up on PR #908. |
|
Lot's of changes so any reasonable review will take weeks. I wrote a review but github deleted it, summary: iCCP: not reviewed When I say "wrong" I mean your PR is wrong, not the code. |
|
Thanks for the review. I understand that fcTL is correct. Could you please clarify what is wrong with the tRNS and eXIf changes, and what behavior you would expect instead? I want to make sure the follow-up patch matches libpng's intended API semantics. I'll leave the iCCP change unchanged for now until it's reviewed. |
|
iCCP: needs a verifiable bug, not a fix. |
Summary
This patch hardens several metadata and chunk validation paths.
Changes
png_inflate_read()and requireZ_STREAM_ENDwhen the declared profile output is exhausted.num_transvalues outside the valid palette range before updating the PNG info state.num_exifvalues before converting the length topng_uint_32.Verification
PNG_TESTS=ON: successfulThe changes are limited to validation/error handling and do not alter valid input handling.