fix: Avoid NULL memcpy in png_set_text - #916
Open
samuelgirmametaferia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
memcpy()with a NULL source pointer whenpng_set_text()receives an iTXt entry with an empty language or translated keyword.png_textexplicitly permitslangandlang_keyto be NULL. The existing code computes a zero length for those fields but still passes the NULL pointer tomemcpy(), which is undefined behavior even when the copy length is zero and is diagnosed by UBSan.Guard the two copies on their computed lengths and extend
pnggetsetso the documented NULL iTXt language pointers are exercised.Validation
git diff --check: passlibpng18with only the regression trigger: UBSan fails atpngset.c:1108withnull pointer passed as argument 2pnggetsetpasses