Code clean-up and simplification - #21

Draft

nayuki wants to merge 21 commits into

pnggroup:mainfrom

nayuki:patch-0

Commits on Sep 13, 2021

Added authorship information.
nayuki
committed
7574032
Fixed indentation to eliminate tabs and consistently use 2 spaces.
nayuki
committed
9e678e9
Changed function signatures to take const char pointers for safety.
nayuki
committed
4838c9c
Changed function signatures to take const pointers when possible for safety.
nayuki
committed
3be2c82
Gave name to an anonymous enum, changed variable types to match.
nayuki
committed
fc2cb26
Converted struct printbuf_state to use bool members instead of int.
nayuki
committed
a32d5c9
Converted command-line flag global variables to be bool instead of int.
nayuki
committed
8ab7584
Converted pngcheck()'s have_<chunk> variables to be bool instead of int.
nayuki
committed
7ca2f3a
Converted pngcheck()'s last_is_IDAT and last_is_JDAT variables to be bool instead of int.
nayuki
committed
f2dcfca
Converted pngcheck()'s miscellaneous variables to be bool instead of int.
nayuki
committed
e4163bf
Converted check_ascii_float()'s relevant variables to be bool instead of int.
nayuki
committed
41ab1e5
Converted miscellaneous variables to be bool instead of int.
nayuki
committed
954c445
Converted two functions' parameters to be bool instead of int.
nayuki
committed
de3f6cf
Converted chunk type bit-testing macros to functions for safety.
nayuki
committed
c30bb99
Reordered declarations pertaining to global error status.
nayuki
committed
d7058ba
Converted global-error macros to functions for safety.
nayuki
committed
66c5281
Converted isASCIIalpha() from macro to a renamed function, tweaked parameter type and declaration ordering.
nayuki
committed
109ef71
Replaced latin1_keyword_forbidden table with a renamed function.
nayuki
committed
860f527
Replaced latin1_text_discouraged table with a renamed function.
nayuki
committed
ec791f3
Added no-op casts to clarify signed-unsigned comparisons and suppress compiler warnings.
nayuki
committed
358368c
Simplified gcf() while producing identical results.
nayuki
committed
e2cfeeb

Navigation Menu

Uh oh!

Code clean-up and simplification - #21

Code clean-up and simplification#21
nayuki wants to merge 21 commits into
pnggroup:mainfrom
nayuki:patch-0

Commits on Sep 13, 2021

Added authorship information.

Fixed indentation to eliminate tabs and consistently use 2 spaces.

Changed function signatures to take const char pointers for safety.

Changed function signatures to take const pointers when possible for safety.

Gave name to an anonymous enum, changed variable types to match.

Converted struct printbuf_state to use bool members instead of int.

Converted command-line flag global variables to be bool instead of int.

Converted pngcheck()'s have_<chunk> variables to be bool instead of int.

Converted pngcheck()'s last_is_IDAT and last_is_JDAT variables to be bool instead of int.

Converted pngcheck()'s miscellaneous variables to be bool instead of int.

Converted check_ascii_float()'s relevant variables to be bool instead of int.

Converted miscellaneous variables to be bool instead of int.

Converted two functions' parameters to be bool instead of int.

Converted chunk type bit-testing macros to functions for safety.

Reordered declarations pertaining to global error status.

Converted global-error macros to functions for safety.

Converted isASCIIalpha() from macro to a renamed function, tweaked parameter type and declaration ordering.

Replaced latin1_keyword_forbidden table with a renamed function.

Replaced latin1_text_discouraged table with a renamed function.

Added no-op casts to clarify signed-unsigned comparisons and suppress compiler warnings.

Simplified gcf() while producing identical results.