Add Makefile build workflow with Windows Makefiles - #55
Closed
ronaldtse wants to merge 3 commits into
Closed
Conversation
…ixes pnggroup#50 Contribution from Ronald Tse (@ronaldtse) of Ribose (@riboseinc/@metanorma)
* Windows Makefiles based on those from Greg Roelofs <newt@pobox.com> and John Bowler <jbowler@acm.org>
Member
|
As I mentioned in PR #52, you should test the Unix Makefile build in there; and not on all platforms, but on one Unix platform only, i.e. the cheapest one, i.e. Ubuntu. Since we won't be integrating this PR anyway, it should be closed. |
Contributor
Author
|
Closing this. The Unix Makefile workflow has been returned to #52 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #52 as requested by @ctruta (FYI @jbowler ) at:
NOTE: This is based on #52, so once #52 is merged this PR needs to be rebased.
This is a split from #52 where:
This PR adds the GitHub Actions build workflow that uses the traditional Makefile workflows for Windows, including:
In accordance to INSTALL.md which describes CMake and Makefiles as both accepted/supported methods to build, two workflows are created:
build-makefile.ymltests the Makefile approach on all supported platformsThis workflow shares a build matrix configuration with the CMake workflow
build.ymlwhich is encoded atmatrix.json.Specifically:
The Windows Makefiles made a return (containing edits from @groelofs and @jbowler) to support the Makefile builds
Makefile builds use the following setup:
makenmakewithMakefile.w32makewithMakefile.mingw(32/64-bit)Credits