Skip to content

Add Makefile build workflow with Windows Makefiles - #55

Closed
ronaldtse wants to merge 3 commits into
pnggroup:mainfrom
claricle:rt-add-makefile-workflows
Closed

Add Makefile build workflow with Windows Makefiles#55
ronaldtse wants to merge 3 commits into
pnggroup:mainfrom
claricle:rt-add-makefile-workflows

Conversation

@ronaldtse

@ronaldtse ronaldtse commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Follow up to #52 as requested by @ctruta (FYI @jbowler ) at:

NOTE: This is based on #52, so once #52 is merged this PR needs to be rebased.

This is a split from #52 where:

This PR adds the GitHub Actions build workflow that uses the traditional Makefile workflows for Windows, including:

  • Windows: 2022 (x64), 11 ARM (arm64), MinGW32, MinGW64

In accordance to INSTALL.md which describes CMake and Makefiles as both accepted/supported methods to build, two workflows are created:

  • build-makefile.yml tests the Makefile approach on all supported platforms

This workflow shares a build matrix configuration with the CMake workflow build.yml which is encoded at matrix.json.

Specifically:

  • The Windows Makefiles made a return (containing edits from @groelofs and @jbowler) to support the Makefile builds

  • Makefile builds use the following setup:

    • Ubuntu/macOS: normal make
    • Windows MSVC: nmake with Makefile.w32
    • Windows MinGW: make with Makefile.mingw (32/64-bit)

Credits

* Windows Makefiles based on those from Greg Roelofs <newt@pobox.com> and John Bowler <jbowler@acm.org>
@ctruta

ctruta commented Jul 17, 2025

Copy link
Copy Markdown
Member

As I mentioned in PR #52, you should test the Unix Makefile build in there; and not on all platforms, but on one Unix platform only, i.e. the cheapest one, i.e. Ubuntu.

Since we won't be integrating this PR anyway, it should be closed.

@ronaldtse

ronaldtse commented Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

Closing this. The Unix Makefile workflow has been returned to #52 .

@ronaldtse ronaldtse closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants