Fix integer overflow in pnm2png height*sizeof(png_byte*) allocation - #4
Open
XananasX7 wants to merge 1 commit into
Open
Fix integer overflow in pnm2png height*sizeof(png_byte*) allocation#4XananasX7 wants to merge 1 commit into
XananasX7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a heap-buffer-overflow in
pnm2png.ccaused by an unchecked integer overflow in the row-pointer allocation.Root Cause
On 32-bit systems where
sizeof(png_byte *)is 4, a crafted PNM image withheight = 0x40000001causes the multiplication to wrap:png_callocallocates only 4 bytes (room for 1 pointer). The subsequent loop writesheight(1,073,741,825) pointers into this 4-byte buffer — an immediate heap-buffer-overflow. Confirmed with ASan/UBSan.Fix
Add a
PNG_SIZE_MAXguard before the multiplication, consistent with how libpng itself guards similar allocations internally:Fixes #825.