PeoplePicker: defaultSelectedUsers issue resolving groups with similar names. #2102
Open
PeoplePicker: defaultSelectedUsers issue resolving groups with similar names. #2102
Conversation
…hen multiple groups hve similar names. pnp#2101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This PR increases the results returned from the searchPersonByEmailOrLogin function that is called by the defaultSelectedUsers prop in the People Picker control. This function was previously hard-coded to return 1 result, which works well when using an email address or login to perform the search, but when a group is used and searched by name, there are instances where groups with a similar name are resolved incorrectly. Increasing the number of results, then filtering the array with the actual query value produces the correct resolved groups. See #2101 for more information. If any adjustments should be made, please let me know and I would be happy to do so!