Skip to content

[release-1.29] Bump Go Jose to v3.0.5, CVE-2026-34986, Buildah to v1.29.8#6825

Merged
lsm5 merged 3 commits into
podman-container-tools:release-1.29from
TomSweeneyRedHat:dev/tsweeney/release-1.29-cve-2025-34986
May 5, 2026
Merged

[release-1.29] Bump Go Jose to v3.0.5, CVE-2026-34986, Buildah to v1.29.8#6825
lsm5 merged 3 commits into
podman-container-tools:release-1.29from
TomSweeneyRedHat:dev/tsweeney/release-1.29-cve-2025-34986

Conversation

@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor

Bump Go Jose to v3.0.5 to address CVE-2026-34986

Fixes: https://redhat.atlassian.net/browse/RHEL-164978, https://redhat.atlassian.net/browse/RHEL-165539

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Bump Go Jose to v3.0.5 to address CVE-2026-34986

Fixes: https://redhat.atlassian.net/browse/RHEL-164978, https://redhat.atlassian.net/browse/RHEL-165539

[NO NEW TESTS NEEDED]

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Apr 29, 2026
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 29, 2026

@lsm5 lsm5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat the Unit tests w/ overlay is warning of some rhel 9.8/10.2 support. The change itself LGTM.

I'd be happy to hit merge but anyway, @containers/buildah-maintainers PTAL

@nalind

nalind commented May 1, 2026

Copy link
Copy Markdown
Contributor

That check in setup.sh should be removed.
The top-level Makefile's "vendor-in-container" target should probably be using golang:1.24, not golang:1.22, to match go.mod. Later branches grep the version from go.mod.
Otherwise LGTM.

@lsm5

lsm5 commented May 1, 2026

Copy link
Copy Markdown
Contributor

we should switch these branches over to something like: #6796 . Currently that's failing too for some reason I'll check on next week once CZ is back online.

@TomSweeneyRedHat do you wanna remove the check in setup.sh? Else, I don't mind checking bypass rules to merge this.

@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor Author

@nalind @lsm5 I'm in process of updating setup.sh and the Makefile. If they pass through, we can just merge this for now and consider #6796 laster

Adjust the Makefile's go version for vendor-in-container to v1.24 to
match the go.mod.  ALso remove the EOL check from cirrus as the date
has been pushed out by the RHEL program.

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Bump Buildah to 1.29.8

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/release-1.29-cve-2025-34986 branch from 93685c9 to 23dbdb3 Compare May 5, 2026 00:07

@lsm5 lsm5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5

lsm5 commented May 5, 2026

Copy link
Copy Markdown
Contributor

I'm gonna bypass rules and merge this. We don't need to care about debian here AFAICT.

@lsm5 lsm5 merged commit 44f67f3 into podman-container-tools:release-1.29 May 5, 2026
24 of 27 checks passed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/release-1.29-cve-2025-34986 branch May 7, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No New Tests Allow PR to proceed without adding regression tests size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants