CI: various small improvements#934
Open
Luap99 wants to merge 9 commits into
Open
Conversation
Do it like in podman and buildah and use a extra lima.yml to deduplicate the yml file. Also while at it touch up the task names, the name is set like the arguments to hack/ci/ci.yml like in podman so we can just copy paste this to reproduce any CI failure locally with that. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Mainly so we trigger it from the main ci.yml and work it in the task dependencies so we do not have to have extra tasks in the merge protection settings. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This should safe some test resources if basic validation fails already. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Because merge protection gates on Total Success we should have a job to ensure the yaml really has the right deps for it to work correctly. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The default github timeout is 6 hours which is way to long. In case there is ever a hang abort after 10 minutes as all these jobs should be quite fast. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
All the jobs should be much faster than this so we do not needs such long timeouts. In case of hangs it is better to abort early. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This action has write access to PRs so we should guard against a compromised tag and only update explicitly via renovate PRs. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
Once this is reviewed I drop the old validate test names from the branch protection so this can be merged |
The tests do not run in parallel so they do not really benefit from that much cpus. Safe some CNCF resources by using smaller runners. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits