fix release action#266
Conversation
We need to include the repo location to the gh cli so it knows where to create the release because we do not have/need a repo checkout here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| RC="--prerelease" | ||
| else | ||
| # check if this version should not be marked latest | ||
| prevvers=$(gh api repos/containers/podman-machine-os/releases/latest --jq '.tag_name') |
There was a problem hiding this comment.
should we update this line too
There was a problem hiding this comment.
it should not be needed because the API path contains the repo
i.e. you can copy paste the command locally and run it in a terminal without a git repo and it works
There was a problem hiding this comment.
if we look at the failed run https://github.com/podman-container-tools/podman-machine-os/actions/runs/27425617798/job/81065872136
it did print v5.8.2,v5.8.3 so the version lookup worked
There was a problem hiding this comment.
Oh i was mostly talking about containers -> podman-container-tools
There was a problem hiding this comment.
Oh i was mostly talking about containers -> podman-container-tools
Oh totally missed that, yeah we should update that as well though because of the redirects it still works. And since the PR is green I rather merge this now and make another one with this fix later.
|
LGTM |
ashley-cui
merged commit f1c8754
into
podman-container-tools:main
2 participants
We need to include the repo location to the gh cli so it knows where to create the release because we do not have/need a repo checkout here.