Indent option explanations using definition lists (:)#2755
Conversation
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
https://github.com/containers/skopeo/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at PRs with unclear copyright status. Thanks!
Thanks for the reminder. I'll look into it later. |
herrenP
force-pushed
the
manpage-indent-fix
branch
from
22217a1 to
1c3712c
Compare
| **--creds** _username[:password]_ for accessing the registry. | ||
| **--creds** _username[:password]_ | ||
|
|
||
| : For accessing the registry |
There was a problem hiding this comment.
Now that this is not on one line, please use “Credentials for accessing the registry”. Similarly the --…creds and …registry-token (“Bearer token …”) options in skopeo-sync.
There was a problem hiding this comment.
Four more instances in skopeo-sync, per git grep -i '^:[ \t]*For ' docs.
There was a problem hiding this comment.
This is still outstanding AFAICT.
|
Other reviewers: highlighting
|
| **--creds** _username[:password]_ for accessing the registry. | ||
| **--creds** _username[:password]_ | ||
|
|
||
| : For accessing the registry |
There was a problem hiding this comment.
Four more instances in skopeo-sync, per git grep -i '^:[ \t]*For ' docs.
herrenP
force-pushed
the
manpage-indent-fix
branch
from
6627ba7 to
64f3add
Compare
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks! Also #2755 (comment) please.
|
LGTM Yikes, what a lot of changes. I hope you were able to do so with AI, or at least some kind of VI/Emacs macro |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Oh, I thought I had already rebased. Really not used to the PR flow. Regarding the mtrmac's comment. I thought that was a heads up for other reviewers. Is there something I need to do? |
|
@herrenP Ooops, ignore my request for tending to @mtrmac's comment. My GitHub window was showing an outdated comment there. I see that you have tended to it. OK, then, just get the rebase done, and it should be GTG. FWIW, it's likely someone came in and updated one or more of your files after you rebased last time. It sometimes gets to be an annoying loop of rebase, push, rebase, push, but it's necessary. |
Thanks! I'll see if I can find time tomorrow. |
|
A friendly reminder that this PR had no activity for 30 days. |
Signed-off-by: herrenP <skoptser@gmail.com>
Signed-off-by: herrenP <skoptser@gmail.com>
Signed-off-by: herrenP <skoptser@gmail.com>
herrenP
force-pushed
the
manpage-indent-fix
branch
from
64f3add to
2814a5d
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
3 participants
This will render fine when generating man page files and also when viewed in vscode using "Markdown Preview Enhanced" extension. The built-in preview does not support definition lists. Also, when users are browsing project files in Github and view any of the .md files they will show a colon in front of each explanation unfortunately.