chore: add action that will click Allow button during podman installa…#285
Open
odockal wants to merge 1 commit into
Open
chore: add action that will click Allow button during podman installa…#285odockal wants to merge 1 commit into
odockal wants to merge 1 commit into
Conversation
Contributor
Author
|
@adrianriobo Not sure about go error handling. It would be great that it works the way, that when there is no button, it wont fail to cover situations where the dialog with button simply does not appear. so the code is more universal. |
odockal
force-pushed
the
issue-158
branch
4 times, most recently
from
097efee to
bed40f5
Compare
…tion on Mac Signed-off-by: Ondrej Dockal <odockal@redhat.com>
benoitf
reviewed
Feb 20, 2025
benoitf
left a comment
benoitf
left a comment
Contributor
There was a problem hiding this comment.
not approving as it seems tests are not passing
| if err := y.Click(installerAllow, delay.SMALL); err != nil { | ||
| return installerError(err) | ||
| } | ||
| // reinitilize installer app |
Contributor
There was a problem hiding this comment.
Suggested change
| // reinitilize installer app | |
| // reinitilize installer app |
typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion on Mac
Fixes: #158