Skip to content

fix: handle kubernetes connection in startProvider function#8629

Merged
lstocchi merged 1 commit into
podman-desktop:mainfrom
lstocchi:i8514
Aug 30, 2024
Merged

fix: handle kubernetes connection in startProvider function#8629
lstocchi merged 1 commit into
podman-desktop:mainfrom
lstocchi:i8514

Conversation

@lstocchi

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR enhances the startProvider function to check for kubernetes connections as well. This would fix an issue faced on crc

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

it resolves #8514

How to test this PR?

  1. run tests
  2. or by using fix: handle error so that it is shown in both page and task manager crc-org/crc-extension#247 try to execute initialize and start from the dashboard.
  • Tests are covering the bug fix or the new feature

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from a team and benoitf as code owners August 28, 2024 13:39
@lstocchi lstocchi requested review from axel7083, cdrage, dgolovin and jeffmaury and removed request for a team August 28, 2024 13:39
@lstocchi

Copy link
Copy Markdown
Contributor Author

@dgolovin @jeffmaury -> for crc-org/crc-extension#247 in crc

@jeffmaury jeffmaury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 2b320e5 into podman-desktop:main Aug 30, 2024
@lstocchi lstocchi deleted the i8514 branch August 30, 2024 07:10
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run ${providerName} button on dashboard provider card does not work for kubernetes connections

4 participants