PoE1: add KeywordPopups tables (3.29) - #234
Merged
Merged
Conversation
3.29 ported the PoE2 keyword popup tables to the PoE1 client. Definitions copied verbatim from poe2/_Core.gql; row sizes and string/foreignrow layout verified against the 3.29.0 client (KeywordPopups: 32 rows x 72 bytes; KeywordPopupItemReference: 2 rows x 93 bytes; KeywordPopupModReference: empty at launch).
SnosMe
reviewed
Jul 25, 2026
| } | ||
|
|
||
| # Ported from PoE2 in 3.29 | ||
| type KeywordPopupItemReference { |
Collaborator
There was a problem hiding this comment.
League specific .gql files are only for league tables. Everything else goes into _Core.
Review feedback: league .gql files are only for league tables.
Contributor
Author
|
Moved to _Core.gql (with # Added 3.29 markers), league file reverted. Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.29 (Curse of the Allflame) added the keyword popup tables to the PoE1 client:
Data/KeywordPopups.datc64,Data/KeywordPopupItemReference.datc64,Data/KeywordPopupModReference.datc64. These are the same tables PoE2 has had inpoe2/_Core.gql— GGG ported them over unchanged, so the definitions here are verbatim copies of the PoE2 ones.Byte-layout verified against the 3.29.0 client:
KeywordPopupsKeywordPopupItemReferenceKeywordPopupModReferenceContent spot-checks:
KeywordPopups:Term/Definitiondecode cleanly for all 32 rows (Valour, Enshrouded Item, Pact Boons/Afflictions, the reworked Abyss terms, the new keystones, etc.). Row 0 is a literal GGGTestrow.KeywordPopupItemReference: its 2 rows (ScryingOrb,DeadMansSulphur) are exactly the 2KeywordPopupsrows with a non-nullItemReferenceand emptyTerm/Definition; theirBaseItemTypeforeignrows resolve to matching rows inBaseItemTypes.npm run generatepasses; the tables emit intoschema-poe1.min.jsonwithvalidFor: 1.