SharingGRDBTestSupport with assertQuery - #133
Merged
Merged
Conversation
rcarver
marked this pull request as draft
August 21, 2025 04:58
rcarver
marked this pull request as ready for review
August 21, 2025 05:24
| ) | ||
| } | ||
| do { | ||
| @Dependency(\.defaultDatabase) var database |
Member
There was a problem hiding this comment.
What do you think of an optional database: Database? parameter like the @Fetch family of property wrappers, which defaults to this dependency?
Member
|
@rcarver This looks good! But we got a test failure for |
Contributor
Author
|
@stephencelis done! Confirmed it fixed via |
mackoj
pushed a commit
to mackoj/sqlite-data
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SharingGRDBTestSupportas a new library, which exposesassertQuerysuch as fromStructuredQueriesTestSupport.However, the API is slightly different
executeargument, as it uses@Dependency(\.defaultDatabase)I ended up just copying the implementation from
StructuredQueriessinceprintTableis private and its version ofassertQuerywould need to be modified for theincludeSQLoption. Could open those up with SPI if you think it's worth it?