Improve some docs. - #135
Merged
Merged
Conversation
stephencelis
approved these changes
Aug 21, 2025
7andres
approved these changes
Aug 22, 2025
| ``` | ||
|
|
||
| This compiles and selects all high priority reminders ordered by their `isCompleted` state. You | ||
| can even leave off thet type annotation for `reminders` because it is inferred from the query. |
There was a problem hiding this comment.
small typo here mate 😄 thet type -> the type
| to learn more about this decision. | ||
|
|
||
| [this article]: https://swiftpackageindex.com/pointfreeco/swift-structured-queries/main/documentation/structuredqueriescore/definingyourschema#Table-definition-tools | ||
|
|
There was a problem hiding this comment.
I think it would be important to find a way to link the information at the top of this section about grdb-migration-docs—which also explains how to perform migrations using Swift code—with this StructuredQueries way
It would also be good to highlight that there are several ways to complete the code snippet marked with // Execute SQL to create tables, and it’d be helpful to include links [or clarify] both to the GRDB approach and to the StructuredQueries approach using the #sql macro!
Member
Author
There was a problem hiding this comment.
Thanks for the feedback! Just pushed some updates.
mackoj
pushed a commit
to mackoj/sqlite-data
that referenced
this pull request
Dec 5, 2025
* Full-text search * wip * wip * Update FTS5.swift * wip * wip * wip * Make inserts more flexible * wip * wip * wip * wip * wip * wip * fix * wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.