Let assertQuery support update queries - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the new
assertQueryto useDatabaseWriteranddatabase.writeto perform the query. This allows assertions overUPDATE ... RETURNINGqueries which can be handy to test complex update logic.Curious if using
writeis expected/ok here. Should there be a more explicit way to opt into it? SincedefaultDatabaseisDatabaseWriterit was otherwise a seamless change.Apologies for missing this on the first version! I found that I was doing
updateassertions in some of my libraries after updating to 0.7.0