Skip to content

Seed database after configuring triggers #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbrandonw merged 2 commits into from
Sep 16, 2025
Merged

Seed database after configuring triggers #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2412600
Seed database after configuring triggers
acosmicflamingo Sep 16, 2025
71a68fb
fix
mbrandonw Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Examples/Reminders/Schema.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,6 @@ func appDatabase() throws -> any DatabaseWriter {
try migrator.migrate(database)

try database.write { db in
if context == .preview {
try db.seedSampleData()
}

try RemindersList.createTemporaryTrigger(after: .insert { new in
RemindersList
.find(new.id)
Expand Down Expand Up @@ -266,6 +262,10 @@ func appDatabase() throws -> any DatabaseWriter {
updateReminderTextTags(for: old.reminderID)
})
.execute(db)

if context == .preview {

@mbrandonw mbrandonw Sep 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched this to only seeding in previews cause it turns out we seed in tests already. and probably best to leave tests responsible for seeding, especially if they want to seed differently from previews.

@acosmicflamingo acosmicflamingo Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, it's actually why I asked but I should've mentioned my reasoning in Slack. Great!

try db.seedSampleData()
}
}

return database
Expand Down