Add a preferredLocales dependency - #468
Merged
stephencelis merged 6 commits intoAug 21, 2026
Merged
Conversation
Expose ordered content-language locales independently from the formatting locale. Evaluate preferred languages on each access and support deterministic test overrides.
stephencelis
approved these changes
Aug 21, 2026
stephencelis
left a comment
stephencelis
left a comment
Member
There was a problem hiding this comment.
Thanks! Made a few small tweaks.
Contributor
Author
|
@stephencelis interesting. I can't discern why an existential is preferable to a closure, seems overly ceremonious with no obvious pay-off. Has guidance around this changed recently? 🤔 I'm not against it btw, just genuinely curious. |
Member
|
@davdroman Mainly provides better identity and memory/storage, though the existential is a wash when it comes to performance, not that this is a performance-critical path. I could try squashing the conformances into a single concrete type, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@Dependency(\.preferredLocales)for ordered content-language preferences, distinct from the formatting-orientedlocaledependency.Discussed in #467.