Skip to content

fix: resolve build errors for Linux - #335

Open
erikbdev wants to merge 1 commit into
pointfreeco:mainfrom
erikbdev:main
Open

fix: resolve build errors for Linux#335
erikbdev wants to merge 1 commit into
pointfreeco:mainfrom
erikbdev:main

Conversation

@erikbdev

@erikbdev erikbdev commented Mar 7, 2026

Copy link
Copy Markdown

Hello!

This pull request resolves issues related to building on non-darwin machines (only tested on Linux).

Changes made:

  • Used conditional compilation to check if system is using Darwin. If true, we can use LocalizedStringResource

If there are any issues feel free to let me know!

@erikbdev erikbdev changed the title fix: resolve build errors for non-apple devices fix: resolve build errors for Linux Mar 7, 2026

@stephencelis stephencelis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbdev This looks good to us! Would you be interested in trying to get Linux CI coverage on this pull request (or another) to avoid regressions? Should we merge things as is?

@erikbdev

erikbdev commented Apr 1, 2026

Copy link
Copy Markdown
Author

@erikbdev This looks good to us! Would you be interested in trying to get Linux CI coverage on this pull request (or another) to avoid regressions? Should we merge things as is?

Sure! I will do a Linux CI coverage once I have time. To ensure this doesn't introduce breaking changes, I suggest we should wait until the CI is completed. :)

@stephencelis

Copy link
Copy Markdown
Member

@erikbdev Just checking in again. If you resolve this conflict we can merge, but it would still be nice to get CI on the repo.

@erikbdev

erikbdev commented Jul 9, 2026

Copy link
Copy Markdown
Author

@erikbdev Just checking in again. If you resolve this conflict we can merge, but it would still be nice to get CI on the repo.

Hey! Sorry for the late reply, but I will work on this before the end of this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants