Skip to content

Enable root view controller replacement in NavigationStackController #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucamegh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable root view controller replacement in NavigationStackController #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71a62ec
add root view controller replacement support
lucamegh Mar 20, 2026
e8c2b4b
Merge branch 'main' into navigationstack-root
stephencelis Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions Sources/UIKitNavigation/Navigation/NavigationStackController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,16 @@
}
}
private let pathDelegate = PathDelegate()
private var root: UIViewController?

public var rootViewController: UIViewController {
didSet {
if viewControllers.isEmpty {
viewControllers = [rootViewController]
} else {
viewControllers[0] = rootViewController
}
}
}

public override weak var delegate: (any UINavigationControllerDelegate)? {
get { pathDelegate.base }
Expand All @@ -36,11 +45,11 @@
path: UIBinding<Data>,
root: () -> UIViewController
) where Data.Element: Hashable {
let root = root()
self.rootViewController = root
super.init(navigationBarClass: navigationBarClass, toolbarClass: toolbarClass)
self._path = path.path
let root = root()
self.root = root
self.viewControllers = [root]
self.viewControllers = [rootViewController]
}

public required init(
Expand All @@ -49,10 +58,10 @@
path: UIBinding<UINavigationPath>,
root: () -> UIViewController
) {
let root = root()
self.rootViewController = root
super.init(navigationBarClass: navigationBarClass, toolbarClass: toolbarClass)
self._path = path.elements
let root = root()
self.root = root
self.viewControllers = [root]
}

Expand All @@ -79,8 +88,8 @@
let difference = newPath.difference(from: viewControllers.compactMap(\.navigationID))

guard !difference.isEmpty else {
if viewControllers.isEmpty, let root {
setViewControllers([root], animated: true)
if viewControllers.isEmpty {
setViewControllers([rootViewController], animated: true)
}
return
}
Expand Down Expand Up @@ -111,7 +120,7 @@
var newPath = newPath
let oldViewControllers =
viewControllers.isEmpty
? root.map { [$0] } ?? []
? [rootViewController]
: viewControllers
var newViewControllers: [UIViewController] = []
newViewControllers.reserveCapacity(max(viewControllers.count, newPath.count))
Expand Down