Use default key base when loading shared readers - #234
Merged
stephencelis merged 4 commits intoJul 31, 2026
Merged
Conversation
ibrahimkteish
marked this pull request as ready for review
July 28, 2026 14:20
Member
|
@ibrahimkteish Thanks for looking into this! Looks like there may be parallel work to do in |
Contributor
Author
|
@stephencelis done |
ibrahimkteish
force-pushed
the
bugfix/default-key-base-lookup
branch
from
July 31, 2026 07:16
3277de6 to
a058049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233.
SharedReader.load(_:)andSharedReader.init(require:)currently use aSharedReaderKey.Defaultwrapper as the persistent-reference lookup key, while the synchronous default-key initializer useskey.base.Mixing these APIs therefore looks up the same ID using different concrete key types, creating a second reference and subscription.
This adds
K.Defaultoverloads that forward tokey.base, matching the existing initializer behavior. It also adds regression tests covering bothloadandrequirefollowed by a property-wrapper reader.