Skip to content

Adopt CasePath protocol #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 4 commits into from
Aug 31, 2026
+96 −96
Merged

Adopt CasePath protocol #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcfe2c0
Adopt `CasePath` protocol
stephencelis Aug 27, 2026
e3310c6
wip
stephencelis Aug 31, 2026
a14b16a
Merge remote-tracking branch 'origin/main' into case-path-protocol
stephencelis Aug 31, 2026
71d352c
Merge branch 'main' into case-path-protocol
stephencelis Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 81 additions & 81 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/pointfreeco/combine-schedulers", from: "1.0.0"),
.package(url: "https://github.com/pointfreeco/swift-case-paths", from: "1.7.3"),
.package(url: "https://github.com/pointfreeco/swift-case-paths", from: "1.10.0"),
.package(url: "https://github.com/pointfreeco/swift-concurrency-extras", from: "1.3.0"),
.package(url: "https://github.com/pointfreeco/swift-custom-dump", from: "1.0.0"),
.package(url: "https://github.com/pointfreeco/swift-dependencies", from: "1.5.1"),
Expand Down
28 changes: 14 additions & 14 deletions Sources/Sharing/Traits/CasePaths.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
extension Shared {
@_disfavoredOverload
public subscript<Member>(
dynamicMember keyPath: KeyPath<Value.AllCasePaths, AnyCasePath<Value, Member>>
dynamicMember keyPath: KeyPath<Value.AllCasePaths, some CasePath<Value, Member> & Sendable>
) -> Shared<Member>?
where Value: CasePathable {
func open(_ reference: some MutableReference<Value>) -> Shared<Member?> {
Expand All @@ -24,7 +24,7 @@
extension SharedReader {
@_disfavoredOverload
public subscript<Member>(
dynamicMember keyPath: KeyPath<Value.AllCasePaths, AnyCasePath<Value, Member>>
dynamicMember keyPath: KeyPath<Value.AllCasePaths, some CasePath<Value, Member> & Sendable>
) -> SharedReader<Member>?
where Value: CasePathable {
func open(_ reference: some Reference<Value>) -> SharedReader<Member?> {
Expand All @@ -37,15 +37,15 @@
}
}

private final class _ReferenceEnumToOptionalCase<Base: Reference, Case>
where Base.Value: CasePathable {
typealias Value = Case?
private final class _ReferenceEnumToOptionalCase<Base: Reference, Path: CasePath & Sendable>
where Base.Value: CasePathable, Path.Root == Base.Value {
typealias Value = Path.Value?
let base: Base
let keyPath: _SendableKeyPath<Base.Value.AllCasePaths, AnyCasePath<Base.Value, Case>>
let casePath: AnyCasePath<Base.Value, Case>
let keyPath: _SendableKeyPath<Base.Value.AllCasePaths, Path>
let casePath: Path

init(
base: Base, keyPath: _SendableKeyPath<Base.Value.AllCasePaths, AnyCasePath<Base.Value, Case>>
base: Base, keyPath: _SendableKeyPath<Base.Value.AllCasePaths, Path>
) {
self.base = base
self.keyPath = keyPath
Expand Down Expand Up @@ -102,15 +102,15 @@
#endif
}

private final class _MutableReferenceEnumToOptionalCase<Base: MutableReference, Case>
where Base.Value: CasePathable {
typealias Value = Case?
private final class _MutableReferenceEnumToOptionalCase<Base: MutableReference, Path: CasePath & Sendable>
where Base.Value: CasePathable, Path.Root == Base.Value {
typealias Value = Path.Value?
let base: Base
let keyPath: _SendableKeyPath<Base.Value.AllCasePaths, AnyCasePath<Base.Value, Case>>
let casePath: AnyCasePath<Base.Value, Case>
let keyPath: _SendableKeyPath<Base.Value.AllCasePaths, Path>
let casePath: Path

init(
base: Base, keyPath: _SendableKeyPath<Base.Value.AllCasePaths, AnyCasePath<Base.Value, Case>>
base: Base, keyPath: _SendableKeyPath<Base.Value.AllCasePaths, Path>
) {
self.base = base
self.keyPath = keyPath
Expand Down
Loading