Revert "package import Foundation.NSData (#231)" - #238
Merged
Merged
Conversation
This reverts commit 4dfe1b9. While the syntax works on macOS, that seems to be an Objective-C fluke, and we're seeing failures on Linux now.
mbrandonw
approved these changes
Aug 31, 2026
Contributor
|
Terribly sorry about that guys. I'll do some digging, most likely the underlying issue is something with our build configuration. |
Contributor
|
Found the underlying issue, it turned out to be our project setup 🙈 #229 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4dfe1b9.
While the syntax works on macOS, that seems to be an Objective-C fluke, and we're seeing failures on Linux now.
@JanGorman I think we'll need some kind of integration-style test to address this. Our Linux CI started failing with this:
And unfortunately doing the
package import classsyntax introduces a warning we can't suppress. Ideally there's a workaround that doesn't require a warning that might get accidentally "fixed" later on.We're going to revert for now, but let us know if you want to dig in deeper.