Add option for analysis mode for perc divergent - #124
Open
StefanoMezzini wants to merge 1 commit into
Open
Conversation
joethorley
requested changes
Aug 24, 2026
joethorley
left a comment
joethorley
left a comment
Member
There was a problem hiding this comment.
Good work - just one requested change.
| mb.nreanalyses = 1L, | ||
| mb.rhat = 1.05, | ||
| mb.esr = 0.1, | ||
| mb.perc_divergent = 0.2, |
Member
There was a problem hiding this comment.
I think this is too high for report (its what we use most of the time).
Would 0.01 be more appropriate. Be good to get Nicole's thoughts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
necessary for
{smbr2}flagging for lack of convergence if too many divergence transitions. (see poissonconsulting/smbr2#33)