Remove re-exports of term's defunct parameters functions and ignore .claude - #85
Open
joethorley wants to merge 2 commits into
Open
Remove re-exports of term's defunct parameters functions and ignore .claude#85joethorley wants to merge 2 commits into
joethorley wants to merge 2 commits into
Conversation
`term::parameters()` and `term::parameters<-()` became defunct in term 0.4.0, so re-exporting them from mcmcr only exposes functions that error when called. - Delete `R/parameters.R`, dropping `parameters()` and `parameters<-()` from mcmcr's exports and the `term` importFrom block - Regenerate `NAMESPACE` and `man/reexports.Rd` BREAKING CHANGE: `mcmcr::parameters()` and `mcmcr::parameters<-()` are no longer exported. Use `pars()` and `pars<-()` instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
CI on this branch is red, but the failure is pre-existing on
The identical failure appears in the last five R-CMD-check runs on Local |
`R CMD check --as-cran` flagged the `.claude` directory under "checking for hidden files and directories". term already carries the same entry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
term::parameters()andterm::`parameters<-`()become defunct in term 0.4.0 (poissonconsulting/term#103). mcmcr re-exports both, so as of that release mcmcr exports two functions that can only error.R/parameters.R, droppingparameters()andparameters<-()from mcmcr's exports and from thetermimportFromblockNAMESPACEandman/reexports.Rd^\.claude$to.Rbuildignore, clearing the "checking for hidden files and directories" NOTE (term already carries this entry)The tests that exercised the re-exports were already removed in #83, so nothing else changes.
Breaking change:
mcmcr::parameters()andmcmcr::parameters<-()are no longer exported. Usepars()andpars<-(). This warrants the 0.7.0 bump thatcoef(directional_information =)is already targeting.Verification
Checked against the term 0.4.0 development version (0.3.7.9019) installed into a scratch library:
devtools::test()on mcmcr main before this change: all tests pass, so this is cleanup rather than a fix for a broken revdepdevtools::check()with these changes:Status: OKpkgbuild::build()confirms.claudeno longer appears in the tarballmcmcr::parameters(): checked mcmcderive, nlist, mbr, embr, smbr2 and jmbr; every hit is a local variable or a package's ownsubset(parameters =)argumentCI on this branch is red for a reason that predates it:
tidy.mcmcr()forwardsdirectional_informationtonlist::tidy.mcmc.list(), which only accepts it in the unreleased nlist 0.5.0. See the comment below.🤖 Generated with Claude Code