Prepare 0.5.0 for CRAN - #62
Open
joethorley wants to merge 4 commits into
Open
Conversation
- Drop the `Remotes:` field and require the released extras (>= 0.10.0), which exports everything nlist uses. - Set the version to 0.5.0 and replace the fledge dev-version stubs in NEWS.md with a curated 0.5.0 section. - Document return values for the `as_term()` methods, which CRAN now requires for all exported functions. - Rewrite cran-comments.md for this release. `R CMD check --as-cran` locally: 0 errors | 0 warnings | 0 notes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`revdepcheck::revdep_check()` against mcmcderive 0.1.2, mcmcr 0.6.2, sims 0.0.4 and universals 0.0.5: 0 new problems, 0 failures. Records the summary in cran-comments.md and adds the revdep/ reports. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
R-devel notes calls to `structure()` using `.Names`, `.Dim` and `.Dimnames`. rhub flagged this on macOS and Windows R-devel; it does not reproduce on R 4.6.1 release or on the rhub linux R-devel image. Renames all 110 occurrences (1 in `R/nlist.R`, the rest dput output in tests) to `names`, `dim` and `dimnames`. `R CMD check --as-cran` locally: 0 errors | 0 warnings | 0 notes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
R-hub linux, macOS and Windows (R-devel) all return Status: OK after the `structure()` special-names fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers items 1, 2, 4 and 5 of the CRAN readiness review, plus the reverse dependency checks (item 3).
Changes
1. Drop
Remotes:— CRAN rejects packages carrying aRemotesfield.extras0.10.0 is now on CRAN and exports every symbol nlist uses (directional_information,fill_all,fill_na,lower,upper,pvalue,svalue,zscore), verified against the CRAN tarball'sNAMESPACE, so the requirement moves fromextras (>= 0.9.0.9000)toextras (>= 0.10.0).2. Version and NEWS —
Version: 0.5.0, matching the"0.5.0"already declared in thetidy()soft-deprecation. The seven fledge dev stubs (0.4.0.9001–0.4.0.9007, five of which read "Same as previous version.") are replaced by a curated section covering thetidy(simplify = TRUE)default change (#61), thedeprecate_stop()conversions (#56), the newdirectional_informationargument (#51), thesubset.nlists()range check (#55), and the documentation work (#60).3. Reverse dependencies —
revdep/set up viausethis::use_revdep()andrevdepcheck::revdep_check()run against all four revdeps. Reports committed.4. Missing
@return— added toas_term.mcmc(),as_term.nlist()andas_term.nlists(), the only exported help files that lacked\value{}. Re-documented with roxygen2 8.0.0.9000.5.
cran-comments.md— rewritten for 0.5.0. The stale\Sexpr{}/build/stage23.rdbnote is kept but now explains the source (inheriting fromgenerics::tidy(), which lists methods via\Sexpr[stage=render,results=rd]).Verification
devtools::check(args = "--as-cran")on macOS with R 4.6 and extras 0.10.0 installed from CRAN:revdepcheck::revdep_check()against mcmcderive 0.1.2, mcmcr 0.6.2, sims 0.0.4, universals 0.0.5:0 new problems, 0 packages failed to check.
Follow-up for mcmcr (not this PR)
Static analysis of the revdep sources surfaced two mcmcr issues that revdepcheck cannot catch, both relevant to mcmcr #84:
mcmcr::tidy.mcmcr()still defaults tosimplify = FALSE, which after this release diverges from nlist'sTRUEand routes mcmcr's default path through nlist'ssimplify = FALSEdeprecation warning.mcmcr/R/tidy.Rcarries@inheritParams nlist::tidy.nlist, but nlist exports notidy.nlist(onlytidy.nlists,tidy.mcmc,tidy.mcmc.list). CRAN tarballs ship pre-built Rd so this does not fail the check, but it will error the next time mcmcr is re-documented.Before submitting
<!-- TODO -->incran-comments.md.fledge-bumpworkflow will movemainto0.5.0.9000the morning after this merges, so build the submission tarball from the taggedv0.5.0commit.🤖 Generated with Claude Code