Rename ssd_ecd()/ssd_ecd_data() to ssd_ecdf()/ssd_ecdf_data() - #180
Open
joethorley wants to merge 3 commits into
Open
Rename ssd_ecd()/ssd_ecd_data() to ssd_ecdf()/ssd_ecdf_data()#180joethorley wants to merge 3 commits into
ssd_ecd()/ssd_ecd_data() to ssd_ecdf()/ssd_ecdf_data()#180joethorley wants to merge 3 commits into
Conversation
Fixes #153 The empirical cumulative distribution function is now named ssd_ecdf() and ssd_ecdf_data(). The old ssd_ecd() and ssd_ecd_data() are soft-deprecated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
Renames the empirical cumulative distribution function to the conventional
ecdfname:ssd_ecd()->ssd_ecdf()ssd_ecd_data()->ssd_ecdf_data()The old names are retained as soft-deprecated wrappers (
lifecycle::deprecate_soft("2.7.0", ...)) that delegate to the new functions, so existing code keeps working. Internal callers (ggproto.R,plot-data.R,ssd-plot.R,ssd_sort_data()) and@seealsolinks now use the new names, and_pkgdown.ymllists the new functions under Miscellaneous and the deprecated ones under Deprecated.Tests
ssd_ecdf()/ssd_ecdf_data()(migrated from the old-name tests).Full test suite passes locally (1340 tests, 0 failures, NOT_CRAN=true).
🤖 Generated with Claude Code