Skip to content

- List dropped folders - #174

Merged
StefanoMezzini merged 30 commits into
mainfrom
list-dropped-folders
Aug 7, 2026
Merged

- List dropped folders#174
StefanoMezzini merged 30 commits into
mainfrom
list-dropped-folders

Conversation

@StefanoMezzini

Copy link
Copy Markdown
Contributor

Fixes #143.

@StefanoMezzini
StefanoMezzini marked this pull request as ready for review June 24, 2026 19:49
@joethorley
joethorley requested a review from aylapear June 27, 2026 01:54
joethorley
joethorley previously approved these changes Jun 27, 2026

@aylapear aylapear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run the tests locally the output is plugged up with outputs from a bunch of the tests. I think they need to be set to quiet or use expect_message/warning to capture them.

Image

@joethorley joethorley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that the option should be sbf.quiet for consistency with the sbf.ask option.

@StefanoMezzini
StefanoMezzini requested a review from joethorley July 8, 2026 14:07
Comment thread R/load.R
Comment thread R/load.R
@StefanoMezzini
StefanoMezzini requested a review from joethorley July 8, 2026 15:34
Comment thread tests/testthat/test-save-load.R Outdated
Comment thread tests/testthat/test-save-load.R Outdated
Comment thread tests/testthat/test-save-load.R Outdated
Comment thread R/load.R Outdated
@StefanoMezzini
StefanoMezzini requested a review from aylapear July 14, 2026 15:47
@StefanoMezzini
StefanoMezzini merged commit 72209c4 into main Aug 7, 2026
9 checks passed
@StefanoMezzini
StefanoMezzini deleted the list-dropped-folders branch August 7, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List what folders are dropped when specifying drop argument

3 participants