Skip to content

Save spatial plots after dropping spatial cols and attributes - #186

Open
StefanoMezzini wants to merge 7 commits into
mainfrom
save-spatial-plot
Open

Save spatial plots after dropping spatial cols and attributes#186
StefanoMezzini wants to merge 7 commits into
mainfrom
save-spatial-plot

Conversation

@StefanoMezzini

Copy link
Copy Markdown
Contributor

Fixes #185. Contains the changes:

  • dropping spatial columns and attributes before saving xlsx file
  • tests for new behaviour
  • moving {sf} to imports for sf::st_drop_geometry()
  • updating {roxygen2} to 8.1.0.9000

@joethorley joethorley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments for consideration.

Comment thread DESCRIPTION Outdated
Comment thread R/save.R Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sbf_save_plot() should drop geometry column before saving xlsx

2 participants