Update test expectations for chk 0.11.0 - #102
Merged
Merged
Conversation
chk 0.11.0 changes the chkor_vld() error message so each condition includes the actual class (e.g. ", not S3 class 'character'."). Match on the version-stable substring so the test passes with both CRAN chk 0.10.0 and chk 0.11.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joethorley
marked this pull request as ready for review
July 15, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chk 0.11.0 (about to be submitted to CRAN) changes the
chkor_vld()error message format. Each condition now reports the actual class of the object, e.g.The expectation in
test-valid-term.Rmatched"\x` must inherit from S3 class 'term'[.]", which required a literal period immediately after'term'` and so no longer matches the new message.Fix
Drop the trailing
[.]so the expectation matches the version-stable substring\x` must inherit from S3 class 'term'`, which appears in both the old and new messages.Compatibility
The test suite passes with both CRAN chk 0.10.0 and the dev build of chk 0.11.0 (548 passing, 0 failures in each), so this can be merged before or after chk 0.11.0 reaches CRAN.
🤖 Generated with Claude Code