Put start and goal settings on the SSS and goal turnpoints - #691
Merged
Merged
Conversation
Opening the start cylinder now edits start type, direction and gates; opening the last turnpoint edits goal type and deadline. The page disclosures still carry the same controls, moved up next to the list. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
pokle
marked this pull request as ready for review
September 6, 2026 22:53
The Type list now follows the identity fields, immediately above the sections that appear from it. On the last turnpoint the untyped option reads Turnpoint (last is goal), because goal is position, not a type. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
Type order is Takeoff, Start, Turnpoint, ESS, Goal. The first added turnpoint is Takeoff, the second Start, and later ones Turnpoint — unless the current last is an explicit Goal, in which case the new last takes Goal and the old one becomes a Turnpoint. Goal is UI-only and strips to untyped in the xctsk, which is how last-is-goal is stored. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
The Type options now read Start Speed Section (SSS) and End Speed Section (ESS) instead of the short Start / ESS labels. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
The route page disclosure and the start-cylinder sheet heading now match the Type list wording. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
Keep the Type list, add-inference and start/goal sheets from this branch together with master's sea-level altitude conversion (draftWithRecord) and the waypoints-page rewrite. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
Adding a Takeoff or Start no longer opens Goal settings — those sheets are about launch and start. Reordering keeps Goal last the same way appending after a Goal does, and a mid-route Type of Goal announces that the row moved. The longer Start Speed Section title wraps on a phone. Co-authored-by: Tushar Pokle <tushar.pokle@gmail.com>
|
Preview Deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the start cylinder on the route editor now edits start type, direction and gates. Opening the last turnpoint edits goal type and deadline.
Type sits immediately above those sections, in this order: Takeoff, Start Speed Section (SSS), Turnpoint, End Speed Section (ESS), Goal.
The route page disclosure and the start-cylinder sheet heading use the same wording: Start Speed Section (SSS).
Adding infers a type from position: first is Takeoff, second is Start, third onwards is Turnpoint. ESS and Goal are never inferred — they have to be picked. If the current last is already Goal, a new add becomes Goal and the old one becomes a Turnpoint, so last-is-goal stays true.
A Takeoff or Start being added does not open Goal settings (those sheets are about launch and start). Reordering keeps Goal last the same way: a Goal that is no longer last becomes a Turnpoint, and a turnpoint moved after Goal takes Goal.
Goal is UI-only. The
.xctskhas no Goal type (the last turnpoint is the goal), so Goal strips to untyped on save and an untyped last loads back as Goal.Merged latest
master(waypoints rewrite, Back-asks-before-discard, altitude zero-is-never-missing).Preview: https://cursor-route-start-goal-sett.glidecomp.pages.dev
How to check
/routepage (for example Task 3 Open).Task 3 Open route with Start Speed Section (SSS) disclosure
Add turnpoint as Takeoff, with no Goal settings
Phone-width route page, Start Speed Section title wraps with no sideways scroll
route-editor-after-master-merge.mp4
To show artifacts inline, enable in settings.