feat: go-to-definition, fix bugs, update deps, remove unused files#635
feat: go-to-definition, fix bugs, update deps, remove unused files#635aldur wants to merge 51 commits intopolarmutex:developfrom
Conversation
the project version is incorrect
also remove some likely ai generated comments
also remove systemd on darwin. this works on my apple sillicon macbook
chore: fix cargo lock
…pport-relative-path feat: support relative path in journal_root
chore: include LICENSE in the packaged crate
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
50439a8 to
9fd398d
Compare
3ebcfde to
d1612d6
Compare
7bb1d6b to
6da1d71
Compare
|
maybe we can close this now? |
|
sorry, only "goto account" feature is merged already, other features are still not supported |
642f0fa to
fdaf53f
Compare
a926916 to
a8b830f
Compare
|
This is a large draft PR that's been open since July 2025. It includes go-to-definition improvements, bug fixes, and dependency updates, but it's a DRAFT and predates significant recent work (including PR #824 which overlaps on go-to-definition). Given the overlap with current development and the draft status, I'm marking this as stale. @aldur — if you'd like to continue this work, please rebase onto main and remove the draft status. Otherwise I'll close it in 2 weeks to keep the PR queue clean. |
|
Thank you! Is there anything in particular you'd like to keep? I can split / prioritize based on what you have in mind for the project. |
I am opening this PR as draft since there is a big intersection with #634 and it probably does too many things at once.
I have also cherry-picked a couple commits that have since been pushed to develop.I have rebased it on develop so that it should include all changes.If interesting we can split it into multiple PRs; the intent is to kickstart the conversation here.
I am opening it against
developand leaving review comments inline to explain the rationale behind the changes.For context, I have been using this project for a while, thank you for creating it!
This PR:
nvimto cope when editing a big Beancount file).handle_, others did not).I have tested my changes against
nvim. I might have obviously missed things, but have tried to add a few tests to increase confidence.