Conversation
67391c8 to
a654317
Compare
913aa71 to
0296216
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #778 +/- ##
===========================================
+ Coverage 76.86% 77.29% +0.42%
===========================================
Files 26 28 +2
Lines 9913 10798 +885
===========================================
+ Hits 7620 8346 +726
- Misses 2293 2452 +159
🚀 New features to boost your workflow:
|
602e923 to
bf6d908
Compare
|
@polarmutex any opinions on this? |
01c281f to
2c77ca2
Compare
59a0548 to
350ae61
Compare
350ae61 to
f670dd8
Compare
|
@polarmutex any opinion? if you don't like this idea I can close it |
|
@trim21 I am still thinking about this, not sure having a python release with pyo3 is worth added complexity. I am sorry if I have not responded quick enough, I am really busy and try to review and support this project. I would like to try to make a great project with your support , I do not like you making a separate repo that is a close clone of this one. What do you want the LSP to do that is not working for you in vscode? |
|
@trim21 to say this again, let me know how we can work together and make a great LSP for beancount. |
a926916 to
a8b830f
Compare
|
PyPI distribution support is a valuable addition for users who install via pip. This is a large PR (+2061/-317 lines). I'll schedule a proper review. A few initial questions:
I'll do a full review this week. |

context: #768 (comment)
this should work as expected on windows
when compiled as a extension, the
Python::attachwill re-use current python interpreter