Skip to content

ci(msrv): enforce Rust 1.88 floor; record authorized F03 evidence alteration - #285

Merged
brianluby merged 1 commit into
mainfrom
feat/msrv-ci-f03-note
Nov 14, 2026
Merged

brianluby merged 1 commit into
mainfrom
feat/msrv-ci-f03-note

Conversation

@brianluby

@brianluby brianluby commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Two owner-approved items from the 2026-11-13 owner decision record.

D7 — MSRV CI job

New msrv job ("MSRV (Rust 1.88)") in .github/workflows/ci.yml builds and tests with the exact declared rust-version (1.88.0) so regressions below the floor fail CI. Follows existing job conventions: pinned action SHAs, timeout-minutes, RUSTC_WRAPPER, lockfile-keyed cargo cache. Runs cargo check --locked --all-targets + cargo test --locked on ubuntu-latest; does not float stable.

D3b — F03 authorized evidence alteration note

  • New dated note: docs/dependency-reviews/2026-11-13-evidence-alteration-note.md, linked from the 2026-10-02 packet README.
  • Records that PR chore(deps): bump the cargo group across 3 directories with 1 update #265 (merged 2026-11-13, merge 52ab80e) authorizedly altered the retained zip version (8.6.0 → 9.0.0) in the pr162/pr163/pr164 Cargo.lock+Cargo.toml snapshots; owner-approved per D3b (keep merged + note). The SHA-256 index discrepancy is authorized, not tampering.
  • Re-pins the affected entries in retained-evidence-index.json (six receipts + the linked README) with new sha256/bytes; original pins preserved in the note and recoverable at a46b07d. All 152 retained entries re-verified against the index.
  • Historical receipt files are not edited.

Verification

  • cargo fmt --check — pass
  • cargo clippy --all-targets -- -D warnings — pass
  • cargo test — 4545 passed, 0 failed (78 suites)
  • MSRV floor verified locally: rustup run 1.88.0 cargo check --locked --all-targets + cargo test --locked — all pass
  • actionlint .github/workflows/ci.yml — clean
  • Pre-commit gates (fmt/clippy/test) passed at commit time

No Rust code changes. Tickets: #5 (F03), #76 (F22/MSRV).

Summary by CodeRabbit

  • Chores
    • Added automated checks to verify the project builds and passes tests with its declared minimum Rust version.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0f1f51ef-ef34-4a43-b63b-9b93376abc70

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow adds an Ubuntu job that uses Rust 1.88.0 to check all targets and run tests with locked dependencies.

Changes: MSRV CI validation

Layer / File(s) Summary
Add MSRV validation job
.github/workflows/ci.yml
The workflow adds a Rust 1.88.0 job with an MSRV-specific Cargo cache. It runs cargo check --locked for all targets and cargo test --locked.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · previous review 8390c

This adds a CI job that checks the project against its declared minimum Rust version and a documentation note. It does not change runtime behavior. The unrelated Chrome prerequisite CI step fails on main as well, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two changes: an MSRV CI job that enforces the Rust 1.88 floor, and a note recording authorized F03 evidence alteration. The first is the code change in the changeset (the msrv job in .…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two changes: an MSRV CI job that enforces the Rust 1.88 floor, and a note recording authorized F03 evidence alteration. The first is the code change in the changeset (the msrv job in .github/workflows/ci.yml). The second is a documentation change in docs/, which is excluded from the review, so the title covers a real part of the PR. The title is specific and does not describe unrelated work. It is somewhat long (76 characters) and packs two items into one line, but it is related to the change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the Rusty trail,
With locked crates packed in a cache pail.
It hops through tests, then checks each target,
At version one-eight-eight, the build grows smarter.
“All green!” it cheers, and nibbles clover.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0cd1f7ea-e992-4620-905b-4db49209f4ea
Commits

Reviewing files that changed from the base of the PR and between 41aa68b and 8390cad.

Files ignored due to path filters: 3

  • docs/dependency-reviews/2026-10-02/README.md is excluded by !docs/**
  • docs/dependency-reviews/2026-10-02/retained-evidence-index.json is excluded by !docs/**
  • docs/dependency-reviews/2026-11-13-evidence-alteration-note.md is excluded by !docs/**
Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copy link
Copy Markdown
Collaborator Author

Code review: MSRV CI job + F03 evidence note — Approve

  • MSRV job: MSRV (Rust 1.88) passed on this PR's head, so the locked dependency set builds and tests on the declared floor. Action SHAs are pinned, RUSTC_WRAPPER is cleared, and the cache key is lockfile-scoped.
  • Evidence re-pin: I recomputed SHA-256 and byte counts for all 152 retained_files entries in retained-evidence-index.json against the files on this branch: 152 matched, 0 mismatched. The note's PR chore(deps): bump the cargo group across 3 directories with 1 update #265 merge commit (52ab80e) matches main's history, and the original pins are preserved in the note and recoverable at a46b07d.
  • The historical receipts are untouched, as the note states.

Optional: CLAUDE.md still describes rust-version = "1.88" as "not a measured current MSRV qualification"; once this job is required, that sentence can be updated.

CI note: "Installed Google Chrome prerequisite (Linux)" fails here but this PR changes no UI; the same step is failing on main (see the review on #286/#288).


Generated by Claude Code

@brianluby
brianluby marked this pull request as ready for review November 14, 2026 22:15
Copilot AI balanced review requested due to automatic review settings November 14, 2026 22:15
@brianluby

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🟢 Approval recommended

The review evidence describes only additive CI and documentation/index updates with clear traceability of the authorized hash re-pin and no unresolved problems indicated, supporting approval readiness.

No open issues 🎉

What changed in this PR

Adds CI enforcement for the repository’s Rust MSRV (1.88.0) and records an owner-authorized alteration to retained F03 dependency-review evidence by documenting and re-pinning affected hashes.

Changes:

  • Add a GitHub Actions MSRV job that runs cargo check --locked --all-targets and cargo test --locked on Rust 1.88.0.
  • Add a dated note documenting the authorized evidence alteration and preserving prior pin details.
  • Update the retained-evidence index and packet README to reflect and link the authorized re-pinning.
File Description
docs/​dependency-reviews/​2026-11-13-evidence-alteration-note.md Adds a dated note documenting the owner-authorized retained-evidence alteration, including before/after pin details for auditability.
docs/​dependency-reviews/​2026-10-02/​retained-evidence-index.json Re-pins SHA-256/bytes for the affected retained artifacts and records an authorized-alteration metadata block in the index.
docs/​dependency-reviews/​2026-10-02/​README.md Updates the packet README to link to and summarize the authorized evidence-alteration note for traceability.
.github/​workflows/​ci.yml Adds an MSRV (Rust 1.88.0) CI job that installs the pinned toolchain and runs locked check/test to prevent regressions below the declared floor.

Review effort: Balanced

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@brianluby

Copy link
Copy Markdown
Collaborator Author

CodeRabbit review: no actionable findings. CI gates (MSRV job, supply-chain bookkeeping) verified green locally; the F03 evidence-alteration note re-pins the authorized #265 receipt changes. Ready for merge.

… alteration

D7 (2026-11-13 owner decision): dedicated MSRV job builds and tests with
the exact declared rust-version (1.88.0) so regressions below the floor
fail CI. Follows existing conventions: pinned action SHAs, timeout,
RUSTC_WRAPPER, lockfile-keyed cargo cache.

D3b (2026-11-13 owner decision): dated F03 note records the authorized
#265 receipt alteration (zip 8.6.0 -> 9.0.0 in pr162/pr163/pr164
Cargo.lock/Cargo.toml snapshots), links it from the packet README, and
re-pins the affected retained-evidence-index entries. The SHA-256
discrepancy is authorized, not tampering; historical receipt files are
not edited and original pins remain recoverable at a46b07d.
@brianluby
brianluby force-pushed the feat/msrv-ci-f03-note branch from 8390cad to db44951 Compare November 14, 2026 23:39
@brianluby
brianluby merged commit 96da807 into main Nov 14, 2026
21 of 22 checks passed
@brianluby
brianluby deleted the feat/msrv-ci-f03-note branch November 14, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants