fix: app startup failure for name mismatches in separate venvs#778
fix: app startup failure for name mismatches in separate venvs#778yaseminozkut wants to merge 3 commits into
Conversation
|
Hi @yaseminozkut, Thank you for the contribution ! However, after discussing with the team, we would rather enforce that the hugging face space name always matches the entry point name. It's already the case when generating an app with Let us know if you still think there is an issue to solve there. Best, Caroline. |
|
problem is there needs to be a name entry point registry because now the ui has no clue what one install the main or the fork. What a nightmare trying to figure out why diff space names showed up as different space install in the ui. People fork these things and honestly shouldn't be able to publish with the same name or something gotta change |
|
Hi @CarolinePascal, @Jacid23 also raised a good point about a different problem for forks sharing the same entry point names. I haven't tested this scenario myself, maybe @Jacid23 can give more explanation. Does it fail to start or start the wrong app, or is it just a UI issue (not clear who's app is it)? If its just a UI issue, maybe usernames from Hugging Face can be added in the UI. I also saw this discussion https://huggingface.co/datasets/pollen-robotics/reachy-mini-official-app-store/discussions/20 that @pierre-rouanet mentioned (maybe its before the enforcing with the Best, |
|
Also pinging @apirrone and @RemiFabre for visibility ! |
Fixes issue #777
_extract_package_info_from_pyprojectfunction to extract the real entry point frompyproject.tomlduring installationentry_point_nameinstead of the space name when loading apps from separate venvs