Skip to content

Fix cmake setup and update HYPRE#96

Open
iiiian wants to merge 3 commits intomainfrom
fix-cuda-setup
Open

Fix cmake setup and update HYPRE#96
iiiian wants to merge 3 commits intomainfrom
fix-cuda-setup

Conversation

@iiiian
Copy link
Copy Markdown
Contributor

@iiiian iiiian commented Apr 6, 2026

Fix cmake bugs and update dependencies so polysolve compiles on modern compiler (gcc 15).

  • Add POLYSOLVE_WITH_CUDA CMake option to toggle project wide cmake setup.
  • Remove out-dated cmake cuda hacks.
  • Update HYPRE from v2.28.0 to v3.1.0 so it compiles on gcc 15.
    • Update HYPRE cmake option name
    • Add cmake hacks to workaround HYPRE uninstall target
    • Add initialization call in hypre solver ctor
  • Strip AMGCL's aggressive diagnostic flags (-Wall, -Wextra, -Wpedantic) to prevent nvcc warning spam
  • Fix namespace issue at explicit template instantiations in CuSolverDN.cu
  • Bump minimum required CMake version to 3.24.0

@iiiian iiiian changed the title Fix cmake setup Fix cmake setup and update HYPRE Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.69%. Comparing base (5d62b80) to head (10c9203).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   81.67%   81.69%   +0.01%     
==========================================
  Files          49       49              
  Lines        2025     2027       +2     
  Branches      269      270       +1     
==========================================
+ Hits         1654     1656       +2     
  Misses        371      371              
Flag Coverage Δ
polysolve 81.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant