[codex] add configurable notification system#83
Draft
DorianZheng wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/electron/main/notifications/with shared types, persisted settings, delivery history, throttling, do-not-disturb handling, macOS delivery, Telegram delivery, and idle-agent pollingmain.ts, preload, and the shared desktop bridge so renderer settings can load, update, and clear notification statereviewandacceptanceemit notifications, and scheduled task failures surface agent-error notificationsWhy
Dune did not have a host-level notification system for workflow milestones or runtime failures. This adds a central notification manager so delivery policy, throttling, quiet hours, and channel fan-out live in one place instead of being scattered across the runtime and UI.
Impact
Validation
pnpm run typecheckpnpm vitest run src/electron/preload.test.ts src/renderer/features/settings/config/settings-sections.test.tswas attempted but failed in this worktree because@vitejs/plugin-reactis not installed in the local test environment