[codex] add configurable notification system for item state changes and agent errors#89
Draft
DorianZheng wants to merge 1 commit into
Draft
[codex] add configurable notification system for item state changes and agent errors#89DorianZheng wants to merge 1 commit into
DorianZheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Dune did not have a configurable desktop notification system for important workflow and agent events, so item lane changes and runtime failures could be missed.
User impact
Users can now control which workflow and agent events generate alerts, keep notifications quiet during configured hours, and review the last 50 delivered notifications from Settings.
Notes
TelegramBridgeexposes a generic outbound host notification API.budget_warningtrigger is present in settings and the notification manager, but there is not yet an existing budget-warning signal in the codebase to emit it.Validation
pnpm typecheckpnpm exec vitest run src/electron/preload.test.ts src/electron/main/notifications/notification-manager.test.ts src/renderer/features/settings/config/settings-sections.test.ts src/renderer/features/settings/notifications/NotificationsSettingsPanel.test.tsxpnpm exec eslint src/electron/main/notifications/*.ts src/renderer/features/settings/notifications/NotificationsSettingsPanel.tsx src/renderer/features/settings/notifications/NotificationsSettingsPanel.test.tsx src/electron/preload.ts src/electron/preload.test.ts src/shared/electron/ipc-channels.ts src/shared/electron/desktop-bridge.ts src/renderer/features/settings/config/settings-sections.ts src/renderer/features/settings/config/settings-sections.test.ts src/renderer/features/settings/types.ts src/renderer/app/testing/setup.ts