Address issue with PATCH payload and complex attributes on the extension schemas#160
Merged
Merged
Conversation
…ion schemas Address the case when sub attributes of the complex attribute belonging to the extension schema could not be assigned properly when processing SCIM PATCH request
pond
approved these changes
Aug 14, 2025
Owner
pond
left a comment
There was a problem hiding this comment.
Nice. Thanks for the excellent test coverage especially - and noticing the bug in the existing shared example which wasn't taking the "operation" parameter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We have an extension schema that uses complex type attributes and currently
PATCHrequests fail if operation payload featurespathkey pointing to such attribute instead of referring to it as part ofvaluepayload, i.e.:The issue is with attributes map for this case where an additional lookup for the extension schema is needed.
Note
I decided to add temporary extension schema in spec to test this case in isolation, but otherwise requires updating a lot in specs.