Skip to content

Address issue with PATCH payload and complex attributes on the extension schemas#160

Merged
pond merged 1 commit into
pond:mainfrom
quorso:users-patch-extension-schema-issue-gem-pr
Aug 14, 2025
Merged

Address issue with PATCH payload and complex attributes on the extension schemas#160
pond merged 1 commit into
pond:mainfrom
quorso:users-patch-extension-schema-issue-gem-pr

Conversation

@aerodynamik
Copy link
Copy Markdown
Contributor

Issue

We have an extension schema that uses complex type attributes and currently PATCH requests fail if operation payload features path key pointing to such attribute instead of referring to it as part of value payload, i.e.:

{
  op: "replace",
  path: "urn:ietf:params:scim:schemas:extension:my_cool_schema:1.0:User:my_complex_attribute",
  value: {
    sub_attribute_1: "oh",
    sub_attribute_2: "no"
  }
}

The issue is with attributes map for this case where an additional lookup for the extension schema is needed.

Note

I decided to add temporary extension schema in spec to test this case in isolation, but otherwise requires updating a lot in specs.

…ion schemas

Address the case when sub attributes of the complex attribute belonging
to the extension schema could not be assigned properly when processing
SCIM PATCH request
Copy link
Copy Markdown
Owner

@pond pond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for the excellent test coverage especially - and noticing the bug in the existing shared example which wasn't taking the "operation" parameter!

@pond pond merged commit b2a6dfc into pond:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants