Skip to content

mk/chroot.mk: check for dracut binary instead of directory - #369

Open
zhouwg wants to merge 1 commit into
pop-os:masterfrom
zhouwg:build_iso_verify
Open

zhouwg wants to merge 1 commit into
pop-os:masterfrom
zhouwg:build_iso_verify

Conversation

@zhouwg

@zhouwg zhouwg commented Sep 13, 2026

Copy link
Copy Markdown

Overview

  • Fix potential issue in mk/chroot.mk

The condition [ -e "$@.partial/usr/lib/dracut" ] tests for directory existence, but the directory can exist (containing only dracut-install) without the dracut binary being installed. This causes the chroot dracut invocation to fail with "command not found" on systems where dracut and initramfs-tools conflict.

Change the condition to [ -x "$@.partial/usr/bin/dracut" ] so the step is correctly skipped when dracut is not available.

  • Refine README.md

Add minimum disk space requirement.

The build consumes approximately 34 GiB of disk space. Note this in the Requirements section to avoid build failures due to insufficient space.

Additional info

Verified on local Linux OS; pop-os_24.04_amd64.iso generated successfully.

zhouwg:$ ls -l build/pop-os/24.04/amd64/pop-os_24.04_amd64.iso
-rw-rw-r-- 1 zhouwg zhouwg 3539992576 Sep 13 11:39 build/pop-os/24.04/amd64/pop-os_24.04_amd64.iso
Screenshot from 2026-09-13 12-17-57

Requirements

  • I have read and agree with the contributing guidelines
  • I have read and agree with the CODE_OF_CONDUCT
  • AI usage disclosure: YES - AI assistance used for fix. All changes reviewed and locally tested; I take full responsibility for this PR.

The condition `[ -e "$@.partial/usr/lib/dracut" ]` tests for directory
existence, but the directory can exist (containing only dracut-install)
without the dracut binary being installed. This causes the chroot dracut
invocation to fail with "command not found" on systems where dracut and
initramfs-tools conflict.

Change the condition to `[ -x "$@.partial/usr/bin/dracut" ]` so the
step is correctly skipped when dracut is not available.

README.md: add minimum disk space requirement

The build consumes approximately 34 GiB of disk space. Note this in the
Requirements section to avoid build failures due to insufficient space.

Assisted-by: OpenCode(Mimo V2.5)
@mmstick
mmstick requested a review from a team September 14, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants