Skip to content

feat: add axes - #2

Merged
popomore merged 1 commit into
mainfrom
feat/axe
Jan 22, 2026
Merged

feat: add axes#2
popomore merged 1 commit into
mainfrom
feat/axe

Conversation

@popomore

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b6037fc06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ufbx/__init__.pyi
Comment on lines +63 to +67
class CoordinateAxes:
"""Scene coordinate axes (right, up, front)."""

right: CoordinateAxis
up: CoordinateAxis

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Export CoordinateAxes in the runtime module

This stub declares a top-level CoordinateAxes, but ufbx/__init__.py never imports it from _ufbx, so ufbx.CoordinateAxes will raise AttributeError at runtime even though type checkers accept it. That mismatch is triggered whenever users follow the stub (e.g., for isinstance(x, ufbx.CoordinateAxes) or type annotations) and will fail in regular execution; consider importing and adding it to __all__ to match the stub and Scene.axes return type.

Useful? React with 👍 / 👎.

@popomore
popomore merged commit a0b78c4 into main Jan 22, 2026
5 checks passed
@popomore
popomore deleted the feat/axe branch January 22, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant