Roadmap plan - #7
Merged
Merged
Conversation
- Added C wrapper functions for vertex_tangents, vertex_bitangents, vertex_colors - Implemented Mesh.vertex_tangent property (required for normal mapping) - Implemented Mesh.vertex_bitangent property (required for normal mapping) - Implemented Mesh.vertex_color property (RGBA vertex colors) - Updated type hints in __init__.pyi - All properties return numpy arrays with zero-copy access Co-authored-by: sakura9515 <sakura9515@gmail.com>
- Implemented Texture.content property (embedded texture data as bytes) - Implemented Texture.has_file property (file reference check) - Implemented Texture.uv_set property (UV set name) - Implemented Texture.wrap_u property (U wrapping mode) - Implemented Texture.wrap_v property (V wrapping mode) - Updated type hints in __init__.pyi - All properties provide direct access to ufbx texture data Co-authored-by: sakura9515 <sakura9515@gmail.com>
- Implemented Node.node_to_world property (world transform matrix) - Implemented Node.node_to_parent property (local transform matrix) - Implemented Node.geometry_transform property (geometry transform) - Added C wrapper functions for all transform accesses - Updated type hints in __init__.pyi - All transforms provide proper coordinate space conversion Co-authored-by: sakura9515 <sakura9515@gmail.com>
- Added ufbx_texture_list typedef - Added ufbx_transform typedef with proper vec3/vec4 fields - Extended ufbx_texture struct with UV and transform fields - Fixed Cython compilation errors Co-authored-by: sakura9515 <sakura9515@gmail.com>
- Added comprehensive tests for Phase 1 critical features - All 14 new tests pass successfully - Updated API.md to mark all Phase 1 & 2 features as complete - Updated implementation status percentages: - Mesh: 53% -> 68% (vertex_tangent, vertex_bitangent, vertex_color) - Texture: 33% -> 67% (content, has_file, uv_set, wrap_u, wrap_v) - Node: 59% -> 76% (node_to_world, node_to_parent, geometry_transform) - Marked critical missing features as COMPLETED - Updated documentation status to Phase 1 & 2 Complete Phase 1 & 2 deliverables: ✅ Normal mapping support (tangent/bitangent) ✅ Vertex color support ✅ Embedded texture access ✅ UV wrapping modes ✅ Complete transform system Co-authored-by: sakura9515 <sakura9515@gmail.com>
Co-authored-by: sakura9515 <sakura9515@gmail.com>
|
Cursor Agent can help with this pull request. Just |
popomore
marked this pull request as ready for review
January 26, 2026 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement core Mesh, Texture, and Node properties to enable PBR rendering, embedded texture access, and a complete transform system as per the roadmap.