Provide access to UV indices data as used by many FBX files - #9
Conversation
This patch exposes the underlying vertex_uv.indices data via uv_indices property.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR introduces UV index access for meshes in the ufbx-python library. A new C wrapper function retrieves UV index data from mesh structures, and a corresponding Python property exposes this as a NumPy array, following the same validation pattern as other mesh accessors. ChangesUV Indices Mesh Accessor
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UV data can be indexed in some FBX files.
This patch exposes the underlying vertex_uv.indices data via uv_indices property.
Tested the fix using local FBX files (the Digital Emilly FBX is a good example of using indexed UV format).
Summary by CodeRabbit
uv_indicesproperty to theMeshclass, enabling retrieval of per-vertex UV index data as a NumPyuint32array view when available.