Skip to content

fix: close MCP client on session_shutdown so pi -p can exit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d0ublecl1ck wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close MCP client on session_shutdown so pi -p can exit #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions extensions/codebase-memory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,12 @@ export default function codebaseMemoryExtension(pi: ExtensionAPI) {
});
}

// Close the MCP child process so the parent event loop can drain
// (without this, pi -p hangs after answering because stdio pipes stay open).
pi.on("session_shutdown", async () => {
await client?.close().catch(() => undefined);
client = undefined;
});

void register().catch(() => undefined); // silent if binary not installed yet
}