chore: mark secret-scan fixtures as fake for external scanners#6
Merged
Conversation
GitGuardian flagged the scan-secrets test fixtures on PR #5. They are the deliberate attack samples that prove the hook blocks secrets — nothing real. Make that machine- and human-obvious: - .gitguardian.yaml ignores hooks/tests/fixtures/** - conn-string fixture now uses fake_user:fake_password_for_tests@localhost (the GitHub-token fixture already uses an alphabet token) - CONTRIBUTING: fixture fakes must be unambiguous; never a real credential, even revoked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5 — this commit was pushed to the branch moments after the merge, so it missed the train. Remediates the GitGuardian alerts on the scan-secrets test fixtures (which are deliberate fakes used to prove the hook blocks secrets):
.gitguardian.yamlignoreshooks/tests/fixtures/**so future scans skip themfake_user:fake_password_for_tests@localhostTest plan
bash hooks/tests/run-all.sh— 68/68 (hook still blocks the defanged string)