fix: make ContentToolResult.error JSON serializable#267
Merged
Conversation
When a tool call fails and the error is stored in ContentToolResult.error, calling .get_turns() and then .model_dump_json() would fail because Exception objects are not JSON serializable by default. This adds a field_serializer and field_validator to ContentToolResult to handle serialization of the error field: - serialize_error: converts Exception to string for JSON output - validate_error: accepts string or Exception during deserialization Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The previous cassette contained placeholder IDs (like "msg_missing_id") that caused VCR body matching to fail in CI. Re-recorded with fresh API responses containing proper IDs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
982a925 to
a3d9728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContentToolResult.errorfield when calling.get_turns()followed by.model_dump_json()Problem
When a tool call fails and the error is stored in
ContentToolResult.error, attempting to serialize the chat turns would fail because PythonExceptionobjects are not JSON serializable by default.Reprex
Solution
Add a
field_serializerandfield_validatortoContentToolResultto handle theerrorfield:serialize_error: convertsExceptionto string for JSON outputvalidate_error: accepts string orExceptionduring deserialization, reconstructing a genericExceptionfrom the stringThis allows round-trip serialization/deserialization of turns containing failed tool results, though the specific exception type is not preserved (only the error message).
Test plan
test_json_serialize_with_tool_failuretest that verifies serialization and deserialization of turns with tool errors🤖 Generated with Claude Code