Skip to content

fix: parse rsconnect-args with shell quoting so values can contain spaces #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nealrichardson merged 2 commits into from
Aug 5, 2026
Merged

fix: parse rsconnect-args with shell quoting so values can contain spaces #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44164f3
fix: parse rsconnect-args with shell quoting so values can contain sp…
tdstein Aug 4, 2026
b5fcc29
simplify: inline rsconnect-args parsing in deploy.sh
github-actions[bot] Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Here are the full list of inputs and outputs; below we describe what exactly is
| `path` | No | Path to the application directory within the repository. Defaults to the repository root. Use this when your app lives in a subdirectory of your repo. |
| `draft` | No | Deploy as a draft (preview) bundle instead of activating it. Defaults to `true` on `pull_request` events and `false` otherwise. Set it explicitly to override--e.g. `false` to publish directly from a PR, or `true` to stage a draft from a push. |
| `github-token` | No | GitHub token for commenting preview URLs on PRs |
| `rsconnect-args` | No | Additional arguments passed to `rsconnect deploy` |
| `rsconnect-args` | No | Additional arguments passed to `rsconnect deploy`. |

#### Outputs

Expand Down
19 changes: 16 additions & 3 deletions deploy/scripts/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Required env vars: CONTENT_GUID, APP_TYPE (resolved by the "Determine app type"
# step: a `posit connect deploy` subcommand, or "manifest")
# Optional env vars: CONFIG_ENTRYPOINT, EXTRA_FILES, DRAFT, GITHUB_EVENT_NAME,
# RSCONNECT_ARGS
# RSCONNECT_ARGS (raw rsconnect-args input, parsed with shlex for shell quoting)

set -euo pipefail

Expand Down Expand Up @@ -99,8 +99,21 @@ if [ "${SEND_METADATA:-true}" = "true" ]; then
fi
fi

# shellcheck disable=SC2086
posit connect deploy "$APP_TYPE" "${DRAFT_ARGS[@]}" --app-id "$CONTENT_GUID" "${ENTRYPOINT_ARGS[@]}" "${METADATA_ARGS[@]}" ${RSCONNECT_ARGS:-} "$DEPLOY_TARGET" "${EXTRA_FILE_ARGS[@]}" 2>&1 | tee deploy.log
RSCONNECT_ARGS_ARR=()
if [ -n "${RSCONNECT_ARGS:-}" ]; then
while IFS= read -r rsconnect_arg; do
[ -n "$rsconnect_arg" ] && RSCONNECT_ARGS_ARR+=("$rsconnect_arg")
done < <(python3 -c "
import shlex, sys
try:
print('\n'.join(shlex.split(sys.argv[1])))
except ValueError as e:
print(f'Error: Could not parse rsconnect-args: {e}', file=sys.stderr)
sys.exit(1)
" "$RSCONNECT_ARGS")
fi

posit connect deploy "$APP_TYPE" "${DRAFT_ARGS[@]}" --app-id "$CONTENT_GUID" "${ENTRYPOINT_ARGS[@]}" "${METADATA_ARGS[@]}" "${RSCONNECT_ARGS_ARR[@]}" "$DEPLOY_TARGET" "${EXTRA_FILE_ARGS[@]}" 2>&1 | tee deploy.log

# Extract URL from logs, stripping ANSI color codes
CONTENT_URL=$(grep "$URL_PATTERN" deploy.log | sed "s/.*$URL_PATTERN //" | sed 's/\x1b\[[0-9;]*m//g')
Expand Down
Loading