feat(express): Automatically suppress non-renderable UI objects#1773
Draft
feat(express): Automatically suppress non-renderable UI objects#1773
Conversation
3f6d2d9 to
6e90032
Compare
6e90032 to
145b5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1771
Example app:
As mentioned in #1771 the above example app would fail to launch in Shiny Express due to the
con.register()line. This PR makes is so that lines with un-renderable objects are not introduced in the UI.It gives a warning message like the following, which we could wordsmith as needed. (Currently a
print()call but we might be able to usewarnings.warn()to include more context.)