Skip to content

Recover from an unusable incremental baseline with a full review - #163

Merged
morgaesis merged 2 commits into
mainfrom
fix/incremental-fallback-full
Aug 24, 2026
Merged

morgaesis merged 2 commits into
mainfrom
fix/incremental-fallback-full

Report no incremental baseline on a review that measured the full change

e5c92f4
Select commit
Loading
Failed to load commit list.
postil-dev / postil/review succeeded Aug 24, 2026 in 23s

No merge-relevant findings

Postil reviewed this change and found nothing that affects the merge decision.

info 1 suppressed
  • Use a valid scope check for sinceSha at src/review.rs:1878: cites a line the named construct does not sit on; severity error, confidence 0.99. incremental is an Option<&str>, but .then(...) is a method on bool, so this expression fails compilation. Replace it with an explicit check based on the actual reconciliation scope, and apply the same correction to the identical expression in the final envelope construction so full fallbacks report sinceSha as null.

Review details